Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NES-190] add named Proxy contracts #4

Merged
merged 2 commits into from
Sep 14, 2024
Merged

[NES-190] add named Proxy contracts #4

merged 2 commits into from
Sep 14, 2024

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Sep 13, 2024

What's new in this PR?

  • Add named Proxy contracts
  • Add CurrencyToken to initial list of ComponentTokens in AggregateToken

Why?

What problem does this solve?

  • It's hard to see which ERC1967Proxy contract is which in the block explorer - this names them

Why is this important?

  • Readability

What's the context?

  • We want the sum of the value of all ComponentTokens to equal the value of circulating AggregateTokens, this is only possible if the CurrencyToken is also a ComponentToken

Copy link

linear bot commented Sep 13, 2024

NES-190

@eyqs eyqs merged commit 24e9524 into main Sep 14, 2024
1 check passed
@eyqs eyqs deleted the eyqs/proxies branch September 14, 2024 17:31
ungaro added a commit to ungaro/plumenetwork-contracts that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants