Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NES-221] implement AmountSeconds accounting #32

Merged
merged 4 commits into from
Oct 14, 2024
Merged

[NES-221] implement AmountSeconds accounting #32

merged 4 commits into from
Oct 14, 2024

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Sep 24, 2024

What's new in this PR?

  • Force everyone to deposit yield only at the current timestamp
  • Use AmountSeconds for accrued yield accounting instead of keeping a linked list of Balance snapshots for each user

Why?

What problem does this solve?
Why is this important?
What's the context?

@linear Linear
Copy link

linear bot commented Sep 24, 2024

NES-221

Purva-Chaudhari
Purva-Chaudhari approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Purva-Chaudhari Purva-Chaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for if needed to deploy urgently.

Removing timestamp looks good,
Will review the patch again for calculating yieldAccured or add test and cover the part.

@eyqs eyqs merged commit 06eb50b into main Oct 14, 2024
1 check passed
@eyqs eyqs deleted the eyqs/NES-221 branch October 14, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Purva-Chaudhari Purva-Chaudhari Purva-Chaudhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyqs @Purva-Chaudhari