Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NES-218] update smart contracts to use interfaces #26

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Sep 23, 2024

What's new in this PR?

For example, instead of typing currencyToken as ERC20, type it as IERC20 instead within the contract itself and within all signatures and interfaces:

  • Cast between IComponentToken and IERC20 for CurrencyToken in Nest contracts
  • Remove unused ADMIN_ROLE in $P
  • Remove unused import when deploying $pUSD
  • Change some functions from public to external
  • Change i++ to ++i
  • Add named returns for impl and hasCode
  • Update comments on isContract to be more accurate

Why?

What problem does this solve?
Why is this important?
What's the context?

Copy link

linear bot commented Sep 23, 2024

NES-218

Copy link
Member

@Purva-Chaudhari Purva-Chaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyqs eyqs merged commit a9c8e44 into main Sep 23, 2024
1 check passed
@eyqs eyqs deleted the eyqs/nes-218 branch September 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants