Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NES-211] resolve two bugs with checking balances and limiting list sizes #23

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Sep 19, 2024

What's new in this PR?

Resolves two bugs:

  • There was no check that the wallet held enough AssetToken.
  • There was a potential DoS vector if users accept a small amount of yield distribution allowance at any time, they could make the list of yield distributions arbitrarily large.

Why?

What problem does this solve?
Why is this important?
What's the context?

Copy link

linear bot commented Sep 19, 2024

NES-211

@eyqs eyqs changed the title [NES-211] validate that there is enough AssetToken to create new yield distributions [NES-211] resolve two bugs with checking balances and limiting list sizes Sep 19, 2024
Copy link
Member

@Purva-Chaudhari Purva-Chaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyqs eyqs merged commit 500b896 into main Sep 20, 2024
1 check passed
@eyqs eyqs deleted the eyqs/tob-1 branch September 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants