Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHAIN-49] add constants so named proxies have different bytecode #17

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Sep 16, 2024

What's new in this PR?

Add public constants in each named proxy.

Why?

What problem does this solve?

  • Right now, all named proxies have the same bytecode, so they all show up as AggregateTokenProxy in contract verification systems.

Why is this important?

  • It's very confusing to interact with what seems to be an AggregateTokenProxy when it actually points to a ComponentToken instead.

What's the context?

Copy link

linear bot commented Sep 16, 2024

CHAIN-49

@eyqs eyqs merged commit 0b0dfaf into main Sep 16, 2024
1 check passed
@eyqs eyqs deleted the eyqs/proxy-constants branch September 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants