Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDE-234] add onlyInitializing reinitializer to ComponentToken #125

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Dec 12, 2024

What's new in this PR?

We have to call __ERC4626_init(asset_) to change the asset for the BoringVaultAdapter, so we need to add a reinitializer to ComponentToken too.

Why?

What problem does this solve?
Why is this important?
What's the context?

Copy link
Contributor

@ungaro ungaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except why do we have reinitializer(3)?

nest/src/token/BoringVaultAdapter.sol Show resolved Hide resolved
@eyqs eyqs merged commit 22072f7 into main Dec 13, 2024
1 check passed
@eyqs eyqs deleted the eyqs/PDE-234 branch December 13, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants