Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDE-198] Add custom code for ComponentToken in supportsInterface #117

Merged
merged 6 commits into from
Dec 11, 2024
Merged

[PDE-198] Add custom code for ComponentToken in supportsInterface #117

merged 6 commits into from
Dec 11, 2024

Conversation

ungaro
Copy link
Contributor

@ungaro ungaro commented Dec 9, 2024

What's new in this PR?

Use CalculateComponentTokenInterfaceId.s.sol to calculate componenttoken interfaceId.

== Logs ==

IComponentToken Interface ID Calculation Results:
  ----------------------------------------
  Interface ID:  0x1816b2a200000000000000000000000000000000000000000000000000000000
  
Function Selectors:
  ----------------------------------------
  requestDeposit:           0x85b77f4500000000000000000000000000000000000000000000000000000000
  deposit:                  0x2e2d298400000000000000000000000000000000000000000000000000000000
  requestRedeem:            0x7d41c86e00000000000000000000000000000000000000000000000000000000
  redeem:                   0xba08765200000000000000000000000000000000000000000000000000000000
  asset:                    0x38d52e0f00000000000000000000000000000000000000000000000000000000
  totalAssets:              0x01e1d11400000000000000000000000000000000000000000000000000000000
  assetsOf:                 0x2c62fa1000000000000000000000000000000000000000000000000000000000
  convertToShares:          0xc6e6f59200000000000000000000000000000000000000000000000000000000
  convertToAssets:          0x07a2d13a00000000000000000000000000000000000000000000000000000000
  pendingDepositRequest:    0x26c6f96c00000000000000000000000000000000000000000000000000000000
  claimableDepositRequest:  0x995ea21a00000000000000000000000000000000000000000000000000000000
  pendingRedeemRequest:     0xf5a23d8d00000000000000000000000000000000000000000000000000000000
  claimableRedeemRequest:   0xeaed1d0700000000000000000000000000000000000000000000000000000000

@ungaro ungaro requested a review from eyqs December 9, 2024 17:12
eyqs
eyqs reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@eyqs eyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same for AggregateToken and BoringVaultAdapter?

@ungaro ungaro requested a review from eyqs December 11, 2024 05:53
eyqs
eyqs approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@eyqs eyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add a check that the manual calculation matches type(IComponentToken).interfaceId in the script

@ungaro ungaro merged commit 3986e92 into main Dec 11, 2024
1 check passed
@ungaro ungaro deleted the alp/PDE-198 branch December 11, 2024 17:28
ungaro added a commit that referenced this pull request Dec 12, 2024
@ungaro
[PDE-198] Add custom code for ComponentToken in supportsInterface (#117)
0a0d75e 
* add componenttoken interface and script to calculate interfaceid

* add BoringVaultAdapter interface, change interfaceId calculation

* double check interfaceIds

* formatting and fixes boringvaultadapter

* delete helper scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyqs eyqs eyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ungaro @eyqs