Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NES-272] [N12] Potential risks of using different participation rates #115

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

ungaro
Copy link
Contributor

@ungaro ungaro commented Dec 9, 2024

…Shares.

What's new in this PR?

modify the previewDeposit function to use the same logic as convertToShares

@ungaro ungaro requested a review from eyqs December 9, 2024 14:58
nest/src/token/BoringVaultAdapter.sol Outdated Show resolved Hide resolved
nest/src/token/BoringVaultAdapter.sol Outdated Show resolved Hide resolved
@ungaro ungaro requested a review from eyqs December 10, 2024 00:54
Copy link
Member

@eyqs eyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyqs eyqs merged commit 6e621ab into main Dec 10, 2024
1 check passed
@eyqs eyqs deleted the alp/NES-272 branch December 10, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants