Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] pUSD comments 2 #108

Merged
merged 3 commits into from
Dec 6, 2024
Merged

[Fix] pUSD comments 2 #108

merged 3 commits into from
Dec 6, 2024

Conversation

ungaro
Copy link
Contributor

@ungaro ungaro commented Dec 3, 2024

What's new in this PR?

  • remove BASE from aggregatetoken, change it's visibility, change IVault contract to IBoringVault
  • vm.skip(true) and return REQUEST_ID

cc @eyqs

@ungaro ungaro requested a review from eyqs December 3, 2024 15:28
Copy link
Member

@eyqs eyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ungaro ungaro merged commit 663410a into main Dec 6, 2024
1 check passed
@ungaro ungaro deleted the alp/NES-255-addons-2 branch December 6, 2024 16:14
ungaro added a commit that referenced this pull request Dec 12, 2024
* remove BASE from componenttoken, change IVault contract to IBoringVault

* vm.skip(true) and return REQUEST_ID

* add _BASE back to componenttoken, change it's visibility, remove from AggregateToken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants