[FEA-1063] remediate Slowmist audit suggestion [N2] (#68)

plumenetwork · Oct 23, 2024 · 6a0e83d · 6a0e83d
1 parent 70e2c22
commit 6a0e83d
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 9 deletions.
diff --git a/nest/src/proxy/AggregateTokenProxy.sol b/nest/src/proxy/AggregateTokenProxy.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract AggregateTokenProxy is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("AggregateTokenProxy");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/nest/src/proxy/FakeComponentTokenProxy.sol b/nest/src/proxy/FakeComponentTokenProxy.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract FakeComponentTokenProxy is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("FakeComponentTokenProxy");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/nest/src/proxy/NestStakingProxy.sol b/nest/src/proxy/NestStakingProxy.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract NestStakingProxy is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("NestStakingProxy");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/nest/src/proxy/USDTProxy.sol b/nest/src/proxy/USDTProxy.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract USDTProxy is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("USDTProxy");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/p/src/proxy/PProxy.sol b/p/src/proxy/PProxy.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract PProxy is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("PProxy");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/plume/src/proxy/FaucetProxy.sol b/plume/src/proxy/FaucetProxy.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract FaucetProxy is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("FaucetProxy");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/staking/src/proxy/PlumePreReserveFund.sol b/staking/src/proxy/PlumePreReserveFund.sol
@@ -6,16 +6,21 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
 /**
  * @title PlumePreReserveFund
  * @author Eugene Y. Q. Shen
- * @notice Proxy contract for SBTCStaking
+ * @notice Proxy contract for ReserveStaking
  */
 contract PlumePreReserveFund is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("PlumePreReserveFund");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }
diff --git a/staking/src/proxy/PlumePreStaking.sol b/staking/src/proxy/PlumePreStaking.sol
@@ -10,12 +10,17 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy
  */
 contract PlumePreStaking is ERC1967Proxy {
 
+    /// @notice Indicates a failure because transferring ETH to the proxy is unsupported
+    error ETHTransferUnsupported();
+
     /// @notice Name of the proxy, used to ensure each named proxy has unique bytecode
     bytes32 public constant PROXY_NAME = keccak256("PlumePreStaking");
 
     constructor(address logic, bytes memory data) ERC1967Proxy(logic, data) { }
 
     /// @dev Fallback function to silence compiler warnings
-    receive() external payable { }
+    receive() external payable {
+        revert ETHTransferUnsupported();
+    }
 
 }