[inferno-vc] Cached client and server logging. More granular cache locks. Cleanup #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smurphy8
approved these changes
Oct 16, 2024
smurphy8
deleted the
albertov_inferno_vc_cache_improvements_and_logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging to cached client to see hits/misses and makes the thundering-herd-prevention locks more granular while only taking the lock when actually fetching upstream. Also does some cleanup in that module so the thundering-herd-prevention logic is easier to inspect and functions have names that better describe what they do. This is 3rd take of #139 but this time the semantics of fetchVCObjectClosureHashes is not modified