Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inferno-ml-server to this repo #109

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Move inferno-ml-server to this repo #109

merged 10 commits into from
Mar 28, 2024

Conversation

ngua
Copy link
Contributor

@ngua ngua commented Mar 28, 2024

Moves most of the things related to inferno-ml-server to this repo, including:

  • the inferno-ml-server Haskell package
  • the base NixOS modules and image configurations
  • the server nixosTest

There are no changes to inferno-ml-server itself beyond some minor renaming in some places, updated comments, etc...

To make it easier to extend the image configurations, I've also added an image-config flake input. This should contain additional NixOS modules to include in the image configuration (they will be automatically included). For this repo, we don't need any additional config, so it's set to a new nix/dummy directory. But it can be overridden elsewhere. I've tried this out with a different repo and it works nicely

I've also included some of the Python packages that I made for training. These aren't strictly related to inferno-ml-server but they might be useful to have here (we also have devShells..pytorch already, so it's in the same vein as that). If we really don't want them we can put them somewhere else

I also noticed that the flake was getting a bit out of control, so I split everything into smaller modules. There's a comment in the flake explaining the new structure. This does not affect actually using the flake -- it's just for internal organization to make things nicer and more maintainable/readable

Copy link
Collaborator

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I notice that some test files seem to be duplicated, e.g. nix/inferno-ml/tests/models/mnist.ts.pt is also at inferno-ml/test/mnist.ts.pt -- is it possible to de-duplicate?

@ngua
Copy link
Contributor Author

ngua commented Mar 28, 2024

@siddharth-krishna Oh, good catch, I guess those are from renaming/moving some things. I'll remove the redundant ones

@ngua ngua merged commit 04a2b66 into main Mar 28, 2024
1 check passed
@ngua ngua deleted the rory-inferno-ml-server branch March 28, 2024 09:51
@siddharth-krishna
Copy link
Collaborator

Thanks, but I notice we still have two mnist.ts.pt files.. I was hoping to keep the repo size down

@ngua
Copy link
Contributor Author

ngua commented Mar 29, 2024

@siddharth-krishna I only see one at nix/inferno-ml/tests/models/mnist.ts.pt, where is the other one?

@siddharth-krishna
Copy link
Collaborator

My bad, I must not have read the find-grep output properly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants