-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inferno-ml-server
to this repo
#109
Conversation
WIP: Move `inferno-ml-server` and related here WIP: Moving Nix things to this repo WIP: Move modules and images here WIP: Move tests here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I notice that some test files seem to be duplicated, e.g. nix/inferno-ml/tests/models/mnist.ts.pt
is also at inferno-ml/test/mnist.ts.pt
-- is it possible to de-duplicate?
@siddharth-krishna Oh, good catch, I guess those are from renaming/moving some things. I'll remove the redundant ones |
Thanks, but I notice we still have two |
@siddharth-krishna I only see one at |
My bad, I must not have read the find-grep output properly! |
Moves most of the things related to
inferno-ml-server
to this repo, including:inferno-ml-server
Haskell packagenixosTest
There are no changes to
inferno-ml-server
itself beyond some minor renaming in some places, updated comments, etc...To make it easier to extend the image configurations, I've also added an
image-config
flake input. This should contain additional NixOS modules to include in the image configuration (they will be automatically included). For this repo, we don't need any additional config, so it's set to a newnix/dummy
directory. But it can be overridden elsewhere. I've tried this out with a different repo and it works nicelyI've also included some of the Python packages that I made for training. These aren't strictly related to
inferno-ml-server
but they might be useful to have here (we also havedevShells..pytorch
already, so it's in the same vein as that). If we really don't want them we can put them somewhere elseI also noticed that the flake was getting a bit out of control, so I split everything into smaller modules. There's a comment in the flake explaining the new structure. This does not affect actually using the flake -- it's just for internal organization to make things nicer and more maintainable/readable