-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - fixedShaped funnel with customizable neck height/width #2334
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ee6352:
|
The feature can be previewed here. |
@bdknox, I haven't reviewed the PR yet, but looking at the website preview, it seems like borders don't work anymore. |
Sorry about that @plouc, I meant to mention that in the PR description and have some documentation on it. I left it without supporting the borders for now because of how borders are currently implemented and how it looks with this shape of the funnel. They clip into the previous parts as seen below. I can look into it if you'd prefer for borders to be supported for this format as well. Otherwise I'll add some info to the PR description and the website info under the |
feat(funnel) - Option to make the funnel chart a fixed shape with customizable neck width/height to more directly resemble a funnel shape.
Three new props for
Funnel
:fixedShape: boolean
neckHeightRatio: number
- only applicable whenfixedShape is true
neckWidthRatio: number
- only applicable whenfixedShape is true
fixedShape.funnel.demo.mov