Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nivo/rects and @nivo/icicles package #1978

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lsagetlethias
Copy link

image
image

Highly inspired from @nivo/sunburst, @nivo/arcs, and https://observablehq.com/@d3/zoomable-icicle.

The main goal was to add a "flat" version of the Sunburst chart.

This PR is pretty complete but some TODO remains which are not critical and I don't know how to resolve them for now:

  • @nivo/rects:
    • Add transition mode like what's arcs package has builtin
    • Create a useAnimatedRect hook for single rect animation
  • @nivo/icicles
    • Figure out why text colors (e.g. "white", "black") are not working with borderColor props (react-spring is during useTransition with text spring values I guess?)
    • Canvas version
  • website
    • add icons and captures for Icicles

@plouc Tell me if anything is missing.

Shout out to my buddy and co author of this packages: @mehdilouraoui.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5708279:

Sandbox Source
nivo Configuration

@lsagetlethias
Copy link
Author

ping @plouc don't hesitate if you need some help for review or merge

@plouc
Copy link
Owner

plouc commented May 10, 2022

@lsagetlethias, I'll try to review it in the upcoming weeks, sorry for the delay.

@lsagetlethias
Copy link
Author

lsagetlethias commented May 10, 2022

Great news! Don't hesitate if you want to live pair-review (in english or french), I can make myself available around your TZ.

@lsagetlethias
Copy link
Author

Hello @plouc , any update on this?

@stale stale bot added stale and removed stale labels Sep 20, 2022
@stale stale bot added the stale label Dec 21, 2022
@lsagetlethias
Copy link
Author

Still revelant

@stale stale bot removed the stale label Dec 21, 2022
@stale stale bot added stale and removed stale labels Mar 23, 2023
@plouc plouc added the pinned label Apr 30, 2023
Repository owner deleted a comment from stale bot Apr 30, 2023
Repository owner deleted a comment from stale bot Apr 30, 2023
Repository owner deleted a comment from lsagetlethias Apr 30, 2023
Repository owner deleted a comment from stale bot Apr 30, 2023
Repository owner deleted a comment from lsagetlethias Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants