-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nivo/rects and @nivo/icicles package #1978
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5708279:
|
ping @plouc don't hesitate if you need some help for review or merge |
@lsagetlethias, I'll try to review it in the upcoming weeks, sorry for the delay. |
Great news! Don't hesitate if you want to live pair-review (in english or french), I can make myself available around your TZ. |
Hello @plouc , any update on this? |
Still revelant |
Highly inspired from @nivo/sunburst, @nivo/arcs, and https://observablehq.com/@d3/zoomable-icicle.
The main goal was to add a "flat" version of the Sunburst chart.
This PR is pretty complete but some TODO remains which are not critical and I don't know how to resolve them for now:
@nivo/rects
:useAnimatedRect
hook for single rect animation@nivo/icicles
borderColor
props (react-spring is duringuseTransition
with text spring values I guess?)@plouc Tell me if anything is missing.
Shout out to my buddy and co author of this packages: @mehdilouraoui.