feat: start work to name the new-look package 'kaleido2' #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: fails some tests - see below.
./README.md
and copy it into./src/py/README.md
.../../README.md
inpyproject.toml
.assets/architecture.svg
showing the old and new designs.src/py/kaleido
assrc/py/kaleido2
.src/py/pyproject.toml
to rename package.src/py/kaleido2/__init__.py
to changekaleido
tokaleido2
.kaleido
- should this change?src/py/kaleido2/scopes/plotly.py
to refer tokaleido2
instead ofkaleido
.After doing all of this, go into
src/py
and:uv venv
and activate the virtual environment (using Python 3.12.5).uv pip install -e .
to create editable install.uv pip install plotly pandas
so that manual tests will run.python tests/manual.py
to run manual tests.Output is as shown below: 7 tests fail with the same error; I presume we're going to have to make changes to plotly.py to pick up
kaleido2
.test-results.zip