Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for weird requests with media types with extra / #173

Closed
wants to merge 1 commit into from

Conversation

djay
Copy link
Member

@djay djay commented Nov 24, 2023

No description provided.

@mister-roboto
Copy link

@djay thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait...I already merged this change in #153, and it is there on main: https://github.com/plone/plone.rest/blob/main/src/plone/rest/negotiation.py#L14

So what is this PR for, and why does it show a diff from main? I must be missing something...

@djay
Copy link
Member Author

djay commented Nov 25, 2023

@davisagli missing nothing but my bad memory. I went to create another PR for this package, found it checked out to my branch and thought I'd never submitted it. Sorry for the confusion

@djay djay closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants