Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not remove the src folder when bulding the docker image #112

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

do not remove the src folder when bulding the docker image #112

wants to merge 4 commits into from

Conversation

erral
Copy link
Member

@erral erral commented Nov 21, 2024

If we remove the src folder, the packages that we may have installed through sources in mx.ini will not be available.

@erral erral requested a review from ericof November 21, 2024 09:41
@Fosten
Copy link

Fosten commented Nov 21, 2024

Yes! Thank you!
Solves half of #108
Also don't need line 23 cd /app

@erral
Copy link
Member Author

erral commented Nov 21, 2024

@Fosten I have updated the PR with the other half. Can you check if it works correctly?

@Fosten
Copy link

Fosten commented Nov 21, 2024

LGTM. One last thing, however. Issue #109 is related.

@erral
Copy link
Member Author

erral commented Nov 22, 2024 •
edited
Loading

@Fosten I added the code you say in #109 but I don't think I get the use-case...

Can you check if the generated template works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericof ericof Awaiting requested review from ericof

@sneridagh sneridagh Awaiting requested review from sneridagh sneridagh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erral @Fosten