Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting Atom and RSS feeds to 10 posts #172

Merged
merged 2 commits into from
May 21, 2015

Conversation

xdaDaveShaw
Copy link
Contributor

As discussed on twitter and mentioned via my blog, NewsBlur has problems with large RSS / Atom feeds. Jekyll supports limiting the number of posts in the feed. I've picked 10 as an arbitrary number.

@ploeh
Copy link
Owner

ploeh commented May 20, 2015

Thank you for your contribution. As explained in #76, Atom feeds should be paged. As described in #77, it would also be nice if the RSS feed is, but I'm not sure if that's doable.

Assuming that it isn't possible paging RSS feeds, we can move forward with the RSS change, but please either revert the change to the Atom feed (by far the easiest solution), or implement paging.

@xdaDaveShaw
Copy link
Contributor Author

Doh! I never thought to look into if you have anything logged for this - I've only just discovered Jekyll and found this setting via Nick Craver's blog. I've reverted the Atom changes, no idea how I would do that with Jekyll or Liquid. Looking at the RSS Spec there's nothing supporting paging.

@ploeh ploeh merged commit 4579e04 into ploeh:master May 21, 2015
@ploeh
Copy link
Owner

ploeh commented May 21, 2015

Thank you! It's now live on the blog. Hope it helps 😄

@ploeh ploeh mentioned this pull request May 21, 2015
@xdaDaveShaw xdaDaveShaw deleted the limiting-feeds branch May 21, 2015 20:23
@xdaDaveShaw
Copy link
Contributor Author

NewsBlur seems to have picked it up. I'll run my Yahoo Pipes along side the RSS until your next blog post to see if it works.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants