fix: Ensure issuesGroupedState is up to date #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SgtPooki
commented
Mar 28, 2023
| @@ -114,7 +105,7 @@ export function RoadmapDetailed({ | |||
|
|
|||
| return innerDayjsDates; | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [issuesGroupedState.length, issuesGroupedId]); | |||
| }, [issuesGroupedState, issuesGroupedId]); | |||
There was a problem hiding this comment.
useHookstateMemo properly recognizes uniqueness of hookState objects.
| setIssuesGroupedState(() => convertIssueDataStateToDetailedViewGroupOld(issueDataState, viewMode, query)) | ||
| } | ||
| }, [viewMode, query, setIssuesGroupedState, issueDataState, groupedIssuesIdPrev, groupedIssuesId]); | ||
| const memoGrouped = useHookstateMemo( |
There was a problem hiding this comment.
useHookstateMemo properly recognizes uniqueness of hookState objects.
Comment on lines
+136
to
+144
| const invalidGroups = issuesGroupedState.filter((group) => group.ornull == null || group.items.ornull == null) | ||
| if (issuesGroupedState.value.length === 0 || invalidGroups.length > 0) { | ||
| if (invalidGroups.length > 0) { | ||
| invalidGroups.forEach((g) => { | ||
| console.warn('Found an invalid group: ', g.value); | ||
| }); | ||
| } | ||
| return <Spinner />; | ||
| } |
There was a problem hiding this comment.
only processing invalidGroups after globalLoadingState check
| const issuesGroupedState = useHookstate<DetailedViewGroup[]>([]); | ||
| const groupedIssuesId = getUniqIdForGroupedIssues(issuesGroupedState.value) | ||
| const groupedIssuesIdPrev = usePrevious(groupedIssuesId); | ||
| const globalLoadingState = useGlobalLoadingState(); |
There was a problem hiding this comment.
moving global loading state up to the top
| @@ -71,10 +71,9 @@ export function RoadmapTabbedView({ | |||
| } | |||
|
|
|||
| return ( | |||
| <Skeleton isLoaded={!globalLoadingState.get()}> | |||
| <Skeleton isLoaded={!globalLoadingState.get()} key={index}> | |||
| @@ -33,13 +33,12 @@ export function GridRow({ | |||
| const viewMode = useViewMode(); | |||
| const routerQuery = useRouter().query; | |||
| const [closestDateIdx, setClosestDateIdx] = useState(Math.round(globalTimeScaler.getColumn(dayjs.utc(milestone.due_date.get()).toDate()))); | |||
| useEffect(() => { | |||
| useHookstateEffect(() => { | |||
There was a problem hiding this comment.
note: useHookstateEffect is supposed to recognize hookstate objects, but doesn't seem to work properly, unlike useHookstateMemo (which does work properly, not rerunning the hook callback if hookstate object wasn't changed)
whizzzkid
approved these changes
Mar 29, 2023
| @@ -5,7 +5,7 @@ const SvgDetailViewIcon = () => ( | |||
| * From https://www.iconfinder.com/icons/326721/list_view_icon#svg | |||
| */ | |||
| <svg width="19" height="14" viewBox="0 0 19 14" xmlns="http://www.w3.org/2000/svg" version="1.1"> | |||
| <g fill="none" fill-rule="evenodd" id="Page-1" stroke="#fff" stroke-width="1"> | |||
| <g fill="none" fillRule="evenodd" id="Page-1" stroke="#fff" strokeWidth="1"> | |||
Comment on lines
+139
to
+141
| invalidGroups.forEach((g) => { | ||
| console.warn('Found an invalid group: ', g.value); | ||
| }); |
There was a problem hiding this comment.
optionally
Suggested change
| invalidGroups.forEach((g) => { | |
| console.warn('Found an invalid group: ', g.value); | |
| }); | |
| invalidGroups.forEach(({value}) => console.warn('Found an invalid group: ', value)); |
SgtPooki
deleted the
347-bug-detail-view-not-loading-properly-on-initial-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #347
demo url: https://starmaps-git-347-bug-detail-view-not-loading-c9426c-ipfs-ignite.vercel.app/roadmap/github.com/protocol/engres/issues/9#detail