Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow updated, take 2 #4290

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Workflow updated, take 2 #4290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
976b943
adds info logging when redirect response fails
gilzow Dec 9, 2024
786f933
checks out the PR head sha for linting
gilzow Dec 9, 2024
954a4c3
Merge branch 'main' into workflow-updated
gilzow Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actions/redirection-verification/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ const verify = async () => {
return response
} catch (reqerr) {
//core.warning(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}`)
// core.debug(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}. More info: `)
// core.debug(reqerr.toJSON())
core.info(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}. More info: `)
core.info(reqerr.toJSON())
let row = [{data: linkify(path, axios.defaults.baseURL)},{data: linkify( anchors[path].to, axios.defaults.baseURL) }]
tableData.push(row)
}
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/linting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@ jobs:
site: ['platform', 'upsun']
steps:
- name: Checkout
uses: actions/checkout@v3

uses: actions/checkout@v4
with:
# we need to checkout the PR repo/branch even if it's a fork because the action in the next step needs to
# check the markdown from the PR itself. Plus, we're only running this job if a PR from fork has been approved
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- uses: ./.github/actions/redirection-verification
- name: Vale
uses: errata-ai/vale-action@reviewdog
with:
Expand Down
Loading