Workflow updated, take 2 #4290
Merged
Workflow updated, take 2 #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR was closed due to PR infra issue.
Why
Workflow updates to correct false positives, and debug failed states
What's changed
The lint-prose job is part of a workflow that uses
pull_request_target. This means that the workflow, for checkouts, will default to using the PR target, not the contents from the PR itself. For the first job in the worflow, this is exactly what we want, but for the lint-prose job, we need to evaluate the markdown in the PR. For this job, we'll update the checkout to use the PR sha.Occasionally, our redirection verification action will fail, showing all redirects as broken. However, our access logs in the PR environment shows the requests and responses as
200. This PR adds extra logging to the action in an effort to diagnose what is happening between the action runner and our PR environment.