Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow updates #4289

Closed
wants to merge 3 commits into from
Closed

Workflow updates #4289

wants to merge 3 commits into from

Conversation

gilzow
Copy link
Collaborator

@gilzow gilzow commented Dec 9, 2024

Why

Workflow updates to correct false positives, and debug failed states

What's changed

The lint-prose job is part of a workflow that uses pull_request_target. This means that the workflow, for checkouts, will default to using the PR target, not the contents from the PR itself. For the first job in the worflow, this is exactly what we want, but for the lint-prose job, we need to evaluate the markdown in the PR. For this job, we'll update the checkout to use the PR sha.

Occasionally, our redirection verification action will fail, showing all redirects as broken. However, our access logs in the PR environment shows the requests and responses as 200. This PR adds extra logging to the action in an effort to diagnose what is happening between the action runner and our PR environment.

@gilzow gilzow closed this Dec 9, 2024
@gilzow gilzow deleted the workflow-updates branch December 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants