Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix broken links #2618

Merged
merged 2 commits into from
Oct 13, 2022
Merged

🐛 Fix broken links #2618

merged 2 commits into from
Oct 13, 2022

Conversation

AnouckColson
Copy link
Contributor

@AnouckColson AnouckColson commented Oct 13, 2022

Why

Relates to #2213

What's changed

Checked all the links. 403 errors seemed resolved. Fixed both 404 by removing broken links.

@AnouckColson AnouckColson added the quick task For quick changes to the docs that should require no more than 15 minutes to review label Oct 13, 2022
@AnouckColson AnouckColson self-assigned this Oct 13, 2022
@github-actions
Copy link

Copy link
Contributor

@CollierCZ CollierCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I'd probably link to Symfony 6.1 rather than just removing the link altogether.

Also, I usually mark PRs about broken links as relating to #2213 rather than closing it because the issue is automatically updated with any new links so we just keep it open. I'll have to document that process too 🤦

@@ -38,7 +38,6 @@ Drupal FAQs, how-to guides and other tutorials right on [Platform.sh Community](
### Symfony templates

* [Symfony 5](https://github.com/symfonycorp/platformsh-symfony-template/tree/5.4)
* [Symfony 6](https://github.com/symfonycorp/platformsh-symfony-template/tree/6.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 The new version is 6.1, so we can link to that rather than deleting the line entirely: https://github.com/symfonycorp/platformsh-symfony-template/tree/6.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I didn't look in the right place to see if there were other versions!

Copy link
Contributor

@CollierCZ CollierCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CollierCZ CollierCZ merged commit 09a766f into main Oct 13, 2022
@CollierCZ CollierCZ deleted the fixbrokenlinks branch October 13, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick task For quick changes to the docs that should require no more than 15 minutes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants