Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix broken links #2286

Merged
merged 2 commits into from
Apr 26, 2022
Merged

🐛 Fix broken links #2286

merged 2 commits into from
Apr 26, 2022

Conversation

CollierCZ
Copy link
Contributor

@CollierCZ CollierCZ commented Apr 14, 2022 •
edited
Loading

Why

  • The Drupal 9 template README changed, so the link to a specific section was broken (as noted in 🐛 Broken links #2213).
  • GitHub restructured their docs

What's changed

  • Changed the link to the general template and redid the other sentences around it to have links at the end of sentences (as in the upcoming style recommendations
  • Redid the links for GitHub
  • Changed a couple of other links that weren't working

@CollierCZ CollierCZ added the quick task For quick changes to the docs that should require no more than 15 minutes to review label Apr 14, 2022
@CollierCZ CollierCZ requested a review from trolologuy April 14, 2022 08:32
@CollierCZ CollierCZ self-assigned this Apr 14, 2022
@github-actions
Copy link

github-actions bot commented Apr 14, 2022 •
edited
Loading

Your Platform.sh environment has successfully deployed. 🚀

See the changed pages:

@CollierCZ CollierCZ changed the title 🐛 Fix broken link 🐛 Fix broken links Apr 25, 2022
trolologuy
trolologuy approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@trolologuy trolologuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Final built pages are working as expected.
  • The information is correct.
  • All links work, including to section headers.

@CollierCZ CollierCZ merged commit 709dbfc into main Apr 26, 2022
@CollierCZ CollierCZ deleted the CollierCZ-linking branch April 26, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trolologuy trolologuy trolologuy approved these changes

Assignees

@CollierCZ CollierCZ

Labels
quick task For quick changes to the docs that should require no more than 15 minutes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CollierCZ @trolologuy