fix(lib/solvers/glpk): parse file following GLPK LP/MIP format #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjherrera
reviewed
Sep 15, 2021
lib/solvers/glpk.rb
Outdated
| command = "#{executable} --lp #{@filename} %s --cuts --output #{@outfile}" | ||
| command %= "--write #{glpk_filename}glpk.sol --wglp #{glpk_filename}glpk.prob" |
There was a problem hiding this comment.
esto no es opcional? como los de abajo que hace options[:gap] ? "--...."? y no cacho muy bien si tiene sentido o no, pero podría ir dentro de ese arreglo
There was a problem hiding this comment.
ah no no es opcional, debería ponerla arriba 😱
lib/solvers/glpk.rb
Outdated
| variables.each do |var| | ||
| var.value = vars_by_name[var.to_s].to_f | ||
| id = column_ids[var&.to_s] |
There was a problem hiding this comment.
cuando es nil la var qué pasa? no importa que var.value al final quede nil?
There was a problem hiding this comment.
mm creo que var no puede ser nil, quizas en ese caso es mejor sacarle el & para que no quede raro 🤔
kyrantonia
force-pushed
the
fix-glpk-solver-file-parser
branch
from
8439ca6
to
7bd76bc
Compare
Previously, a monkeypatch to Kernel#method_missing and Object#const_missing was used. The first one was causing significant app slowing in development, so this attempts to fix that
…-apps Fix kernel method missing slowing apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexto
Rulp es una librería que permite obtener soluciones a problemas de programación lineal (LP) y programación entera mixta (MIP) facilitando la generación del archivo con el problema y la lectura del archivo con la solución.
Para utilizarla se debe instalar un solver, para el caso de Platanus se utilizar GLPK en la versión 4.64.
Problema
Se encontró un bug utilizando la librería que generaba que el archivo de respuesta no se leyera correctamente.
Solución
Se cambiará la manera en que se lee la respuesta utilizando el formato estándarizado llamado GLPK LP/MIP. La documentación aparece en el Manual de referencia GNU Linear Programming Kit en el capitulo Utility API routines secciones Problem data reading/writing routines y Problem solution reading/writing routines.
Qué se está haciendo
n j COL NAME(ver foto Problema nuevo formato).s bas ROWS COLS PST DST OBJs ipt ROWS COLS SST OBJs mip ROWS COLS SST OBJj COL ST PRIM DUALj COL PRIM DUALj COL VALstore_resultssus respectivas soluciones.Otros
Solución formato antiguo
Problema nuevo formato
Solución nuevo formato