Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title handling to StateBuilder #487

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

mpapis
Copy link
Contributor

@mpapis mpapis commented Nov 4, 2023

Motivation / Background

This Pull Request has been created because I found myself manually re-implementing every state column row adding title's to them.

Detail

This Pull Request changes StateBuilder to support title: ... option.

Additional information

activeadmin_addons_state_title

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a concise description of what changed and why.
  • Tests are added or updated if you fix a bug or add a feature.
  • Documentation has been added or updated if you add a feature or modify an existing one.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature (under the "Unreleased" heading if this is not a version change).
  • My changes don't introduce any linter rule violations.

Copy link
Member

@rjherrera rjherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there! long overdue, sorry about that. I guess you are already using it in your projects :).

I'm not sure I understand the meaning of the title option, is it for further understanding of the value? Wouldn't that be explained by the title of the column. I don't know the intended usage. But the PR looks good, i'd love it if you can explain.

@mpapis
Copy link
Contributor Author

mpapis commented Sep 11, 2024

title is the on hover label displayed in html, example screenshot in Additional information ☝🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants