-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds sortable option to select2 tags input field #423
base: master
Are you sure you want to change the base?
Conversation
* it allows the user to sort the tags in the select2 field when a 'sortable' option is specified * it uses the sortable plugin from jquery-ui since it is included in activeadmin * it remove the sorting in `array_to_select_options` because it shouldn't change the original order
Hi, sorry for the late reply. This looks interesting, but unfortunately we have released a beta for v2 where we drop support for select2, so these changes wouldn't work directly. Would you be willing to rebase from master and adapt this so it works with slim select, the alternative we are now using? I can then review this PR more thoroughly.
|
@difernandez Thanks a lot for your message. We will definitely try out the new version you are going to release. Although, I'm not sure yet when this will happen. Then I will also look into this issue. Slim select definitely looks interesting. |
@joker-777 we don't have an ETA on when we're going to release v2 out of beta, we want to test it a little more and see if we find any issues. But the current beta version should be stable, if you want to try it there. Thank you for your contribution! |
array_to_select_options
because it shouldn't change the original order