chore(code-organization): re-organized code

GitOrigin-RevId: fcaf9fc0d925b9a11e2347b5ce295fd4bfb92b67
plasmicapp · Nov 14, 2024 · fe5d56f · fe5d56f
1 parent e8d82d1
commit fe5d56f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 14 deletions.
diff --git a/platform/wab/src/wab/client/components/sidebar/LeftGeneralTokensPanel.tsx b/platform/wab/src/wab/client/components/sidebar/LeftGeneralTokensPanel.tsx
@@ -123,10 +123,7 @@ const LeftGeneralTokensPanel = observer(function LeftGeneralTokensPanel() {
   );
 
   const [isTargeting, setIsTargeting] = React.useState(false);
-  const viewCtx = studioCtx?.focusedViewCtx();
-  const resolver = React.useCallback(useClientTokenResolver(), [
-    viewCtx?.isFirstRenderComplete,
-  ]);
+  const resolver = useClientTokenResolver();
 
   const getTokenValue = React.useCallback(
     (token: StyleToken) => {

diff --git a/platform/wab/src/wab/client/components/widgets/ColorPicker/client-token-resolver.tsx b/platform/wab/src/wab/client/components/widgets/ColorPicker/client-token-resolver.tsx
@@ -8,6 +8,7 @@ import {
   makeTokenResolver,
 } from "@/wab/shared/cached-selectors";
 import { StyleToken } from "@/wab/shared/model/classes";
+import * as React from "react";
 
 const RE_VARIABLE_REF = /var\((--[^)]+)\)/;
 
@@ -29,7 +30,10 @@ const RE_VARIABLE_REF = /var\((--[^)]+)\)/;
 export function useClientTokenResolver(): TokenValueResolver {
   const sc = useStudioCtx();
   const vc = sc.focusedViewCtx();
-  const resolver = makeTokenResolver(sc.site);
+
+  const resolver = React.useCallback(makeTokenResolver(sc.site), [
+    vc?.isFirstRenderComplete,
+  ]);
   return makeClientTokenResolver(resolver, vc ?? sc);
 }
 

diff --git a/platform/wab/src/wab/client/cseval.ts b/platform/wab/src/wab/client/cseval.ts
@@ -75,6 +75,14 @@ export abstract class BaseCliSvrEvaluator {
   private _postEvalTasks: (() => any)[] = [];
   private _contextFactory: ContextFactory;
   private _renderState: RenderState;
+  private _isFirstRenderComplete = observable.box(false);
+
+  get isFirstRenderComplete() {
+    return this._isFirstRenderComplete.get();
+  }
+  set isFirstRenderComplete(v) {
+    this._isFirstRenderComplete.set(v);
+  }
 
   constructor({ viewCtx }: { viewCtx: ViewCtx }) {
     this._viewCtx = viewCtx;
@@ -164,7 +172,7 @@ export abstract class BaseCliSvrEvaluator {
       this.rootNode = this.renderRoot();
       viewCtx.canvasCtx.rerender(this.rootNode, viewCtx);
       this.addPostEval(() => {
-        viewCtx.isFirstRenderComplete = true;
+        this.isFirstRenderComplete = true;
       });
     }
   }

diff --git a/platform/wab/src/wab/client/studio-ctx/view-ctx.ts b/platform/wab/src/wab/client/studio-ctx/view-ctx.ts
@@ -174,6 +174,10 @@ export class ViewCtx extends WithDbCtx {
 
   csEvaluator: DevCliSvrEvaluator;
 
+  get isFirstRenderComplete() {
+    return this.csEvaluator.isFirstRenderComplete;
+  }
+
   private disposals: (() => void)[] = [];
   private _isDisposed = false;
 
@@ -182,14 +186,6 @@ export class ViewCtx extends WithDbCtx {
     return this._nextFocusedTpl;
   }
 
-  private _isFirstRenderComplete = observable.box(false);
-  get isFirstRenderComplete() {
-    return this._isFirstRenderComplete.get();
-  }
-  set isFirstRenderComplete(v) {
-    this._isFirstRenderComplete.set(v);
-  }
-
   private _highlightParam = observable.box<
     | {
         param: Param;