fix: added flex-direction to unremovableProps and check isPropRemovab…

…le before removing prop GitOrigin-RevId: e768743ec2ad297277b32239c5c30ec2d5a90ffa
plasmicapp · Oct 29, 2024 · 34b96b0 · 34b96b0
1 parent cfbbbd6
commit 34b96b0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/platform/wab/src/wab/client/components/sidebar/ThemeInitialStylesPanel.tsx b/platform/wab/src/wab/client/components/sidebar/ThemeInitialStylesPanel.tsx
@@ -31,7 +31,10 @@ const InitialsForm = observer(function InitialsForm(props: {
   addItemKey: AddItemKey;
 }) {
   const { studioCtx, rs, addItemKey } = props;
-  const expsProvider = new SingleRsExpsProvider(rs, studioCtx, ["display"]);
+  const expsProvider = new SingleRsExpsProvider(rs, studioCtx, [
+    "display",
+    "flex-direction",
+  ]);
   return providesStyleComponent(
     mkStyleComponent({ expsProvider }),
     `${rs.uid}`

diff --git a/platform/wab/src/wab/client/components/style-controls/StyleComponent.tsx b/platform/wab/src/wab/client/components/style-controls/StyleComponent.tsx
@@ -768,7 +768,7 @@ function StylePanelSection_(
             await studioCtx.changeUnsafe(() => {
               const exp = expsProvider.targetExp();
               for (const prop of L.without(styleProps, ...unremovableProps)) {
-                if (exp.has(prop)) {
+                if (exp.has(prop) && expsProvider.isPropRemovable(prop)) {
                   exp.clear(prop);
                 }
               }