Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kopia CLI common args and flags #2

Draft
wants to merge 7 commits into
base: kopia-cli-core-infra
Choose a base branch
from

Conversation

plar
Copy link
Owner

@plar plar commented Feb 5, 2024

Change Overview

This PR is the second in the series of PRs that will add a new way to build Kopia CLI commands.

Previous PRs:

  1. PR-2649

This PR introduces common argument structures and flags for Kopia CLI, along with extended error definitions:

  • pkg/kopia/cli/CommonArgs and pkg/kopia/cli/CacheArgs structs encapsulate common command-line arguments and cache-related arguments for the Kopia CLI.
  • pkg/kopia/cli/internal/flag/common package presents common and cache-related flags for the Kopia CLI.
  • pkg/kopia/cli/errors.go is expanded with specific errors for common and cache arguments. (ErrInvalidCommonArgs, ErrInvalidCacheArgs, and ErrInvalidID).

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@plar plar self-assigned this Feb 5, 2024
@plar plar force-pushed the kopia-cli-core-infra branch from af7fce3 to 618c926 Compare February 5, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant