feat: add support for searching yarn 3 lock files

planningcenter · Sep 26, 2024 · 1a5ad3b · 1a5ad3b
1 parent 99352ba
commit 1a5ad3b
Show file tree

Hide file tree

Showing 3 changed files with 547 additions and 1 deletion.
diff --git a/deploy/lib/deployer/repo/version_compare.rb b/deploy/lib/deployer/repo/version_compare.rb
@@ -30,7 +30,7 @@ def current_version
       def find_current_version
         match =
           yarn_lock_file.match(
-            /"#{package_name}@[^"]+":\n\s\sversion "([^"]+)"/m
+            /"#{Regexp.escape(package_name)}@[^"]+":?\n\s+version:?\s"?([^"\n]+)/m
           )
         package_not_found if match.nil?
 

diff --git a/deploy/spec/deployer/repo/version_compare_spec.rb b/deploy/spec/deployer/repo/version_compare_spec.rb
@@ -1,5 +1,16 @@
 describe Deployer::Repo::VersionCompare do
   describe "#major_upgrade?" do
+    it "works when detecting a yarn 3 file" do
+      version_compare =
+        described_class.new(
+          package_name: "@planningcenter/tapestry-react",
+          version: "4.6.0",
+          yarn_lock_file_path: "spec/fixtures/yarn3.lock"
+        )
+
+      expect(version_compare.major_upgrade?).to eq(false)
+    end
+
     it "works when detecting a yarn file" do
       version_compare =
         described_class.new(