Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanup #35

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Miscellaneous cleanup #35

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
436e398
Eslint -> ESLint
sheck Oct 8, 2024
436d9d9
Prefix automated test commits messages
sheck Oct 8, 2024
8c1391e
Include exit code in debug output
sheck Oct 8, 2024
84ea858
Update ignored file to reproduce parsing error
sheck Oct 10, 2024
54de0db
Automated: Undo simulated changes
sheck Oct 10, 2024
914a375
Automated: Update test target sha
sheck Oct 10, 2024
3affcca
Automated: Simulate changes
sheck Oct 10, 2024
7d1b5fb
Use extensions input to filter files passed to ESLint
sheck Oct 8, 2024
61837c7
More Eslint -> ESLint
sheck Oct 10, 2024
3496f8f
Merge pull request #36 from planningcenter/ns/norubylint
sheck Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: "Balto - Eslint"
description: "Run eslint on your repo"
name: "Balto - ESLint"
description: "Run ESLint on your repo"
runs:
using: node20
main: dist/index.js
Expand Down
6 changes: 3 additions & 3 deletions devbox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
"cp test/snapshots/base/* test/v7",
"cp test/snapshots/base/* test/v8",
"cp test/snapshots/base/* test/v9",
"git add . && git commit -m 'Undo simulated changes'",
"git add . && git commit -m 'Automated: Undo simulated changes'",
"echo \"{ \\\"pull_request\\\": { \\\"base\\\": { \\\"sha\\\": \\\"$(git rev-parse HEAD)\\\" } } }\" > test/pull_request_event_payload.json",
"git add . && git commit -m 'Update test target sha'",
"git add . && git commit -m 'Automated: Update test target sha'",
"cp test/snapshots/updates/* test/v6",
"cp test/snapshots/updates/* test/v7",
"cp test/snapshots/updates/* test/v8",
"cp test/snapshots/updates/* test/v9",
"git add . && git commit -m 'Simulate changes'"
"git add . && git commit -m 'Automated: Simulate changes'"
]
}
}
Expand Down
3 changes: 2 additions & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,15 @@ async function run() {

core.debug(`Changed files: ${changedFiles}`)

let { stdout: eslintOut } = await getExecOutput(
let { stdout: eslintOut, exitCode } = await getExecOutput(
"npx eslint --format=json",
changedFiles,
// Eslint will return exit code 1 if it finds linting problems, but that is
// expected and we don't want to stop execution because of it.
{ ignoreReturnCode: true },
)
let eslintJson = JSON.parse(eslintOut)
core.debug(`Eslint exit code: ${exitCode}`)

let promises: Array<Promise<EslintResult>> = eslintJson.map(
(resultObject: ResultObject) => EslintResult.for(resultObject, compareSha),
Expand Down
Loading