Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Card Archiving Functionality with Documentation Updates #724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robsonvnt
Copy link
Contributor

Description:

This pull request introduces the functionality to archive cards within the system, utilizing the existing delete confirmation popup to minimize code changes. The feature has been implemented across both the backend and frontend and includes the necessary database updates.

Main Changes:

  • Implementation of the option to archive cards.
  • Creation of a 'status' column in the cards table to manage the archiving state, along with corresponding database migrations.
  • Reuse of the delete confirmation popup for the archiving action.
  • Improvements to the development environment documentation to assist new contributors.

Observations:

  • Currently, I have implemented only the archiving functionality. A method to unarchive cards still needs to be developed.
  • I am seeking suggestions to improve the implementation, considering my limited experience with JavaScript, React, Redux, and Redux-Saga.
  • I was unable to find an "alternate outline" icon in Semantic-UI that was suitable for this functionality. Any recommendations for icons are welcome.

Request for Feedback:

Given my limited experience with these technologies, I am open to receiving feedback on the coding practices adopted, as well as suggestions for improvements or corrections that could enhance the quality and maintainability of the code.

Next Steps:

  • Development of the functionality to unarchive cards.
  • Continuous improvement of the documentation.

Robson Ventura Rodrigues added 2 commits April 22, 2024 13:57
…responding migrations

- Implemented the option to archive cards in the system, with support in both backend and frontend.
- Created 'status' column in the cards table to manage archiving status.
- Developed necessary database migrations for the new column.
- Reused the delete confirmation popup to confirm archiving, minimizing code changes.
- Modifications made to backend handlers and frontend UI to support the archiving functionality.
@meltyshev
Copy link
Member

Hi! Thanks for working on this 🙏

We've already started working on archiving in v2, but we can't move it here since the code is already very different. I'll try to check everything out this week.

@robsonvnt
Copy link
Contributor Author

Is V2 in another repository?

@meltyshev
Copy link
Member

Is V2 in another repository?

Nope, it will be the same repo when we finish.

@meltyshev
Copy link
Member

Hi! I apologize for not replying here for a while.

I've tested a bit and have a few notes:

  • Wouldn't there be a problem with card positioning with this approach? Since the cards are still stored in the same list (just marked as archived). Or probably they should be removed from repositioning process.
  • There may also be a problem that all cards are always being loaded with a board, which can cause loading problems if there are a lot of archived cards.

Should we wait until the unarchiving is done?

BTW, thanks for improving the development environment documentation :)

@robsonvnt
Copy link
Contributor Author

Hi Maksim,

I haven't had time to look at the project in the past few weeks. I'm sorry for the delay in responding.

Thank you for the feedback. I will work on it in my spare time over the next few weeks.

But I have a question: you mentioned that this code would be difficult to reuse in the next version. Do you think it's still worth working on it?

@meltyshev
Copy link
Member

Hi Robson,

I haven't had time to look at the project in the past few weeks. I'm sorry for the delay in responding.

No worries, you don't need to apologize for that 😄

But I have a question: you mentioned that this code would be difficult to reuse in the next version. Do you think it's still worth working on it?

Yeah, that's a good question... I think the important point here is to understand how much you need this feature right now. For example, if it's much needed for your work and you have some time to implement and share it. We need a few more months to release v2, but it's very hard to say exactly how many as our resources are very limited. But I can already say for sure that archiving is already implemented in v2 along with search, restore, and it's possible to archive an infinite number of cards without any impact on board loading. If you decide it's best not to continue, we apologize for that and for the time you've invested.

@robsonvnt
Copy link
Contributor Author

Hi,
For now, I created a list as an "archive," and sometimes I delete it and recreate it. So, it's not very necessary. I started to implement it as a support for the community that has helped me a lot with this project. So, I can wait.
;)

@yakuptekin
Copy link

@meltyshev Hello, will the card archiving feature be added or will it come in v2?

@meltyshev
Copy link
Member

@meltyshev Hello, will the card archiving feature be added or will it come in v2?

Hi! It's gonna be in v2 and we've already solved it. But unfortunately we can't port this to the current version, as the codebases are already very different :(

@yakuptekin
Copy link

@meltyshev Hello, will the card archiving feature be added or will it come in v2?

Hi! It's gonna be in v2 and we've already solved it. But unfortunately we can't port this to the current version, as the codebases are already very different :(

I understand If the V2 repository was truly public, we could support it and complete it quickly. :)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Robson Ventura Rodrigues seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants