[Example] Add Collection View Supplementary Views #63
Conversation
| UINib(nibName: "CollectionToolCell", bundle: nil), | ||
| forCellWithReuseIdentifier: "CollectionToolCell" | ||
| ) | ||
|
|
||
|
|
||
| collectionView.register(UINib(nibName: "CollectionViewHeaderView", bundle: nil), forCellWithReuseIdentifier: "CollectionViewHeaderView") | ||
| flowLayout.headerReferenceSize = CGSize(width: 375, height: 25) |
There was a problem hiding this comment.
@jessesquires - Note it seems that in order to have the supplementary view delegate calls called I had to explicitly set the flowLayout's headerReferenceSize. We probably want to ensure that a user doesn't have to do this somehow. This bug also could have been introduced maybe due to the refactoring happening in the Collection View types.
There was a problem hiding this comment.
This was always a problem I think. Related: #49
You either set this property, or implement FlowLayoutDelegate
| UINib(nibName: "CollectionToolCell", bundle: nil), | ||
| forCellWithReuseIdentifier: "CollectionToolCell" | ||
| ) | ||
|
|
||
|
|
||
| collectionView.register(UINib(nibName: "CollectionViewHeaderView", bundle: nil), forCellWithReuseIdentifier: "CollectionViewHeaderView") |
There was a problem hiding this comment.
this isn't a cell. it's a supplementary view.
you need collectionView.register(, forSupplementaryViewOfKind:, withReuseIdentifier: )
There was a problem hiding this comment.
oh wait. actually no, you shouldn't have to register explicitly. this can be removed.
| diffingKey: group.name | ||
| let headerViewModel = CollectionViewHeaderModel( | ||
| title: group.name, | ||
| height: nil, |
There was a problem hiding this comment.
wouldn't this fix your header size problem?
There was a problem hiding this comment.
Yikes - let me try that
|
@jessesquires - updated |
Changes in this pull request
Add Collection View Supplementary Views