Nip56 buttons #44
Merged
Nip56 buttons #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a branch that solves the issue described in slawlor/ractor#225 here we depend on a fork own by us to solve this
Pull Request Test Coverage Report for Build 9875620291Details
💛 - Coveralls |
dcadenas
commented
Jul 10, 2024
| @@ -22,8 +22,8 @@ libc = "0.2.155" | |||
| log = "0.4.21" | |||
| metrics = "0.23.0" | |||
| metrics-exporter-prometheus = "0.15.0" | |||
| nostr-sdk = "0.31.0" | |||
| ractor = "0.10.3" | |||
| nostr-sdk = { git = "https://github.com/rust-nostr/nostr.git", ref = "d244d10f53bf0ad2a1e84fffdf658c84d7bcce0c" } | |||
There was a problem hiding this comment.
This is a temporary change so that a PR I added is included and we don't need to wait for the new release
dcadenas
commented
Jul 10, 2024
| nostr-sdk = "0.31.0" | ||
| ractor = "0.10.3" | ||
| nostr-sdk = { git = "https://github.com/rust-nostr/nostr.git", ref = "d244d10f53bf0ad2a1e84fffdf658c84d7bcce0c" } | ||
| ractor = { git = "https://github.com/planetary-social/ractor.git", branch = "output_ports" } |
There was a problem hiding this comment.
The output_ports branch solves an edge case with the library that's still not part of the main branch
2 tasks
|
I tested this locally and integrated to everything through ngrok so I'll go ahead and merge, we can always open another PR for any code related change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of planetary-social/nos#1247