Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "track Mac installations on Posthog" #1742

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Revert "track Mac installations on Posthog" #1742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 3 additions & 43 deletions Nos/Extensions/Bundle+Current.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Foundation
import Security

private class CurrentBundle {}

Expand Down Expand Up @@ -29,52 +28,13 @@ extension Bundle {
}

/// > Warning: This method relies on undocumented implementation details to determine the installation source
/// and may break in future iOS / macOS releases.

/// Returns whether the bundle was signed for TestFlight beta distribution by checking
/// the existence of a specific extension (marker OID) on the code signing certificate on macOS.
///
/// and may break in future iOS releases.
/// https://gist.github.com/lukaskubanek/cbfcab29c0c93e0e9e0a16ab09586996
/// Checks the app's receipt URL to determine if it contains the TestFlight-specific
/// "sandboxReceipt" identifier on iOS.
/// "sandboxReceipt" identifier.
/// - Returns: `true` if the app was installed through TestFlight, `false` otherwise.
/// This routine is inspired by the source code from ProcInfo, the underlying library
/// of the WhatsYourSign code signature checking tool developed by Objective-See. Initially,
/// it checked the common name but was changed to an extension check to make it more
/// future-proof.
///
/// For more information, see the following references:
/// - https://github.com/objective-see/ProcInfo/blob/master/procInfo/Signing.m#L184-L247
/// - https://gist.github.com/lukaskubanek/cbfcab29c0c93e0e9e0a16ab09586996#gistcomment-3993808
private var isTestFlight: Bool {
#if os(macOS)
var status = noErr

var code: SecStaticCode?
status = SecStaticCodeCreateWithPath(bundleURL as CFURL, [], &code)

guard status == noErr, let code = code else { return false }

var requirement: SecRequirement?
status = SecRequirementCreateWithString(
"anchor apple generic and certificate leaf[field.1.2.840.113635.100.6.1.25.1]" as CFString,
[], // default
&requirement
)

guard status == noErr, let requirement = requirement else { return false }

status = SecStaticCodeCheckValidity(
code,
[], // default
requirement
)

return status == errSecSuccess
#elseif os(iOS)
Bundle.main.appStoreReceiptURL?.lastPathComponent == "sandboxReceipt"
#else
return false
#endif
}

/// Returns the app's installation source: debug, TestFlight, or App Store.
Expand Down
Loading