Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "track Mac installations on Posthog" #1742

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Revert "track Mac installations on Posthog" #1742

merged 1 commit into from
Jan 24, 2025

Conversation

pelumy
Copy link
Contributor

@pelumy pelumy commented Jan 24, 2025

Reverts #1737 based on the discussion here on slack.

@joshuatbrown
Copy link
Contributor

👀

joshuatbrown
joshuatbrown approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App runs and works! Can't really test the analytics by running it but hopefully all is well after we merge and people use it.

@joshuatbrown joshuatbrown added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 651d878 Jan 24, 2025
6 of 7 checks passed
@joshuatbrown joshuatbrown deleted the revert-1737-it/130-track-mac-installation branch January 24, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuatbrown joshuatbrown joshuatbrown approved these changes

@mplorentz mplorentz Awaiting requested review from mplorentz mplorentz is a code owner

@bryanmontz bryanmontz Awaiting requested review from bryanmontz bryanmontz is a code owner

Assignees
No one assigned
Labels
Skip-Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelumy @joshuatbrown