Merge pull request #1686 from planetary-social/bdm/more-strings

minor strings simplifications
planetary-social · Nov 25, 2024 · 8a2e975 · 8a2e975
2 parents 6b502f1 + 7cfa9da
commit 8a2e975
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix tapping follower notification not opening follower profile. [#11](https://github.com/verse-pbc/issues/issues/11)
 
 ### Internal Changes
+- minor strings simplifications
 
 ## [1.0.1] - 2024-10-28Z
 

diff --git a/Nos/Views/Home/HomeFeedView.swift b/Nos/Views/Home/HomeFeedView.swift
@@ -145,7 +145,7 @@ struct HomeFeedView: View {
                 } label: {
                     Image(systemName: "line.3.horizontal.decrease.circle")
                         .foregroundStyle(Color.secondaryTxt)
-                        .accessibilityLabel(Text("filter"))
+                        .accessibilityLabel("filter")
                 }
                 .frame(minWidth: 40, minHeight: 40)
             }

diff --git a/Nos/Views/NoteComposer/ComposerActionBar.swift b/Nos/Views/NoteComposer/ComposerActionBar.swift
@@ -119,7 +119,7 @@ struct ComposerActionBar: View {
                 .frame(minWidth: 44, minHeight: 44)
         }
         .padding(.leading, 8)
-        .accessibilityLabel(Text("attachMedia"))
+        .accessibilityLabel("attachMedia")
     }
 
     /// Expiration Time
@@ -135,7 +135,7 @@ struct ComposerActionBar: View {
                         self.expirationTime = $0 ? option.timeInterval : nil
                     })
                 )
-                .accessibilityLabel(Text("expirationDate"))
+                .accessibilityLabel("expirationDate")
                 .padding(12)
             } else {
                 Button {

diff --git a/Nos/Views/NoteComposer/NoteComposer.swift b/Nos/Views/NoteComposer/NoteComposer.swift
@@ -191,7 +191,7 @@ struct NoteComposer: View {
                 }
             }
             .background(Color.appBg)
-            .navigationBarTitle(String(localized: "newNote"), displayMode: .inline)
+            .navigationBarTitle("newNote", displayMode: .inline)
             .toolbarBackground(.visible, for: .navigationBar)
             .toolbarBackground(Color.cardBgBottom, for: .navigationBar)
             .toolbar {

diff --git a/Nos/Views/Onboarding/OnboardingLoginView.swift b/Nos/Views/Onboarding/OnboardingLoginView.swift
@@ -34,7 +34,7 @@ struct OnboardingLoginView: View {
         VStack {
             Form {
                 Section {
-                    SecureField(String(localized: "privateKeyPlaceholder"), text: $privateKeyString)
+                    SecureField("privateKeyPlaceholder", text: $privateKeyString)
                         .foregroundColor(.primaryTxt)
                 } header: {
                     Text("pasteYourSecretKey")

diff --git a/Nos/Views/Settings/DeleteConfirmationView.swift b/Nos/Views/Settings/DeleteConfirmationView.swift
@@ -50,13 +50,13 @@ struct DeleteConfirmationView: View {
     /// Creates the title and message view for the delete confirmation.
     private func titleMessageView() -> some View {
         VStack(spacing: 0) {
-            Text(String(localized: "deleteAccount"))
+            Text("deleteAccount")
                 .font(.headline)
                 .fontWeight(.bold)
                 .padding(.bottom, 10)
                 .padding(.top, 18)
 
-            Text(String(localized: "deleteAccountMessage"))
+            Text("deleteAccountMessage")
                 .font(.footnote)
                 .fixedSize(horizontal: false, vertical: true)
                 .multilineTextAlignment(.center)
@@ -101,7 +101,7 @@ struct DeleteConfirmationView: View {
         onCancel: @escaping () -> Void
     ) -> some View {
         HStack {
-            Button(String(localized: "cancel")) {
+            Button("cancel") {
                 onCancel()
             }
             .frame(maxWidth: .infinity)
@@ -111,7 +111,7 @@ struct DeleteConfirmationView: View {
                 .frame(width: 1, height: 50)
                 .background(Color.actionSheetDivider)
 
-            Button(String(localized: "delete")) {
+            Button("delete") {
                 onDelete()
             }
             .frame(maxWidth: .infinity)

diff --git a/Nos/Views/Settings/SettingsView.swift b/Nos/Views/Settings/SettingsView.swift
@@ -44,7 +44,7 @@ struct SettingsView: View {
                         .foregroundColor(.primaryTxt)
                         .font(.clarity(.regular, textStyle: .body))
                         .lineLimit(1)
-                        .accessibilityLabel(Text("privateKey"))
+                        .accessibilityLabel("privateKey")
 
                     Spacer()