Subscribe to vanish_requests stream for deletion #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to update the ansible script to add the REDIS_URL |
mplorentz
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Is this the new preferred convention to just name this compose.yml instead of docker-compose.yml?
There was a problem hiding this comment.
Yes, I suspect that it's related to the change in which now it's docker compose vs docker-compose binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR subscribes to the
vanish_requestsRedis stream and deletes data from the DB on each new request for a certain pubkey. I also updated the docker compose file to ease local testing with Redis and nosrelay, not just the firestore emulator.I didn't add tests but I tested manually locally as it seems pretty safe and I'm worried about having time for the other tasks pending.
This is part of https://github.com/planetary-social/infrastructure/issues/139