액션내 사용 NCG 주소 변경 #3112
Open
액션내 사용 NCG 주소 변경 #3112
+124
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ipdae
commented
Dec 31, 2024
ipdae
commented
- 9c-dev-v2 NCG 수수료 주소 변경하기 #2911 에서 누락되거나 새로 추가된 액션에서 사용된 NCG 수수료 주소를 통일합니다.
- @OnedgeLee 전체적인 변경사항이 문제가 있을지 확인 부탁드립니다.
- @U-lis 어드벤쳐 보스의 주소 변경이 문제 없을지 확인 부탁드립니다.
OnedgeLee
approved these changes
Jan 2, 2025
| @@ -133,9 +135,16 @@ public override IWorld Execute(IActionContext context) | |||
| states.GetBalance(seasonBountyBoardAddress, bountyBoard.totalBounty().Currency) | |||
| ) | |||
| { | |||
| var feeAddress = Addresses.RewardPool; | |||
| // TODO: [GuildMigration] Remove this after migration | |||
| if (states.GetDelegationMigrationHeight() is long migrationHeight | |||
There was a problem hiding this comment.
이건 3개 체인 모두 마이그레이션 끝났으니 싹 정리해서 지워버릴까 싶은데, 비상용으로 혹시나 싶어 아직 살려두고 있네요. 일단 일관성 위해서 넣어두고, 제가 다음 업데이트쯤 해서 한번에 지우든지 하겠습니다.
U-lis
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.