Feature/fix create avatar random #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ipdae
reviewed
Dec 31, 2024
| @@ -21,15 +21,19 @@ namespace Lib9c.DevExtensions.Manager.Contents | |||
| /// </summary> | |||
| public static class CreateAvatarManager | |||
| { | |||
| // TODO: Costume과 Grimoire, Aura에 한해 하드코딩같은 형태로 구현되어 있음. 추후 수정 필요. | |||
| private const int AddItemCount = 10; | |||
There was a problem hiding this comment.
로컬 테스트 과정에서 상대적으로 수량이 적은 아이템들의 숫자를 임의로 늘려준거라고 이야기 되었습니다.
ipdae
approved these changes
Dec 31, 2024
eugene-doobu
merged commit f3396de
into
feature/obsolete-additem
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
아래 pr 머지 후 dev로 pr target 바꾸고 머지하겠습니다
#3108