Active release unbonding #3102
Merged
Active release unbonding #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnedgeLee
force-pushed
the
feature/active-release-unbonding
branch
from
31936f3 to
125ee60
Compare
s2quake
reviewed
Dec 31, 2024
s2quake
reviewed
Dec 31, 2024
| DelegateeAddress = delegateeAddress; | ||
| DelegateeAccountAddress = delegateeAccountAddress; | ||
| DelegationCurrency = new Currency(bencoded[2]); | ||
| RewardCurrencies = ((List)bencoded[3]).Select(v => new Currency(v)).ToImmutableSortedSet(_currencyComparer); |
There was a problem hiding this comment.
https://github.com/microsoft/referencesource/blob/51cf7850defa8a17d815b4700b67116e3fa283c2/mscorlib/system/stringcomparer.cs#L24
처럼 CurrencyComparer 클래스내에 정적 속성을 제공하고 그걸 사용할 수 있는 방법이 있습니다.
_currencyComparer 대신에 CurrencyComparer.Default 를 사용하는 것이지요
OnedgeLee
force-pushed
the
feature/active-release-unbonding
branch
13 times, most recently
from
d596287 to
6328d39
Compare
|
@ipdae 혹시 a2179b1 커밋에 대해서만 좀 디테일하게 리뷰 요청드려도 괜찮을까요? 편의상, 증액을 Staking, 감액을 Unstaking이라 부릅니다.
해당 변경사항 취소되었습니다 |
OnedgeLee
force-pushed
the
feature/active-release-unbonding
branch
4 times, most recently
from
de40b14 to
a717d07
Compare
OnedgeLee
force-pushed
the
feature/active-release-unbonding
branch
from
3bc8409 to
9ea8e11
Compare
OnedgeLee
merged commit 7e98e07
into
planetarium:refactor/guild-and-unbonding
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.