-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RewardBase #3065
Merged
OnedgeLee
merged 20 commits into
planetarium:fix/distribution
from
OnedgeLee:feature/reward-base
Dec 12, 2024
Merged
Introduce RewardBase #3065
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
728004a
feat: Introduce RewardBase
OnedgeLee 5ae345e
feat: Implement Getter and Setter for RewardBase
OnedgeLee 00dca35
feat: Make use of RewardBase
OnedgeLee dee20cb
fix: Fix to return null when RewardBase not exists
OnedgeLee da8e214
fix: Fix malfunctions for RewardBase
OnedgeLee 77f9444
fix: Malfunctions for reward
OnedgeLee b64c676
test: Fix tests for rewards
OnedgeLee 8680558
fix: Reward migration
OnedgeLee 75ee32b
test: Add reward migration test
OnedgeLee 211421c
chore: Redefine RewardBase.Margin as a constant
OnedgeLee b40b9a0
chore: Fix Equals for RewardBase
OnedgeLee 22e55f6
fix: Fix Migration to skip set RewardBase when not needed
OnedgeLee 25b17cb
doc: Add docstrings for RewardBase
OnedgeLee 4cdcc5b
fix: Fix bug for zero-transfer
OnedgeLee 519eb30
chore: Apply reviews for better structure.
OnedgeLee 01791cd
chore: Fix RewardBase to use BigInteger instead of FAV
OnedgeLee 023c2f5
chore: Change MaxAbstainAllowance to 9
OnedgeLee e6e35c5
fix: ReleaseUnbondings to set unbondings properly
OnedgeLee a683969
chore: Rename parameter name as camelCase
OnedgeLee 9e8d87c
test: Fix reward calculation test method
OnedgeLee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, is this migration running at the end of blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this migration is run on the delegation.
(Will be held on the
Stake
action)So, I expect two staking take place for proper migration.