-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix msgpack exception formatter #2963
Feature/fix msgpack exception formatter #2963
Conversation
build-for-unity 에서 실패하고있는데 이거 job자체를 확인 부탁드려도 될까요? |
private static readonly Dictionary<Type, object> FormatterMap = new Dictionary<Type, object>() | ||
private static readonly Dictionary<Type, object> FormatterMap = new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 lib9c를 사용하는 NineChronicles의 유니티 엔진 버전은 2021.3.37f1로 C# 9.0 버전을 지원하고 있습니다.
하지만 본 저장소에서 build-for-unity
스크립트가 .NET Standard 2.1
로 동작하고 있는 점 때문에 기본 언어 버전이 C# 8.0
으로 동작하게 되는 데 원인이 있습니다.
main.yml 스크립트를 개선해서 <LangVersion>9</LangVersion>
설정을 추가해보는 게 좋겠어요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이슈로 남겨뒀어요. #2964
@boscohyun 님의 커밋 c53349a 체리픽하여 추가하였습니다
#2803
https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md