Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimization get avatar state #2953

Conversation

eugene-doobu
Copy link
Member

액션에서 사용하는 GetAvatarState에서 필요한 상태만 가져오도록 변경하여 성능을 개선합니다.

성능비교

SweepAdventureBoss

전 Execute → 1088ms
후 Execute → 1000ms (avatar차이 40)

Wanted

전 Execute → 210ms
후 Execute → 110ms (avatar차이 100)

@eugene-doobu eugene-doobu requested review from ipdae and U-lis October 28, 2024 02:22
@eugene-doobu eugene-doobu self-assigned this Oct 28, 2024
@eugene-doobu eugene-doobu added the enhancement New feature or request label Oct 28, 2024
@eugene-doobu eugene-doobu added this to the v250.0.0 milestone Oct 28, 2024
@eugene-doobu eugene-doobu linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Member

@ipdae ipdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetAvatarState에서 필요한 상태만 가져오게 고친 pr로 보이는데, diff에는 안잡히지만 수정된 액션에서의 SetAvatarState도 확인해보면 좋을것 같습니다.

Lib9c/Action/CreateAvatar.cs Show resolved Hide resolved
@eugene-doobu eugene-doobu merged commit b8b8a4d into planetarium:development Nov 1, 2024
8 checks passed
@eugene-doobu eugene-doobu deleted the feature/optimization-get-avatar-state branch November 1, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

액션 실행속도 최적화 (GetAvatarState)
3 participants