Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused actions #2685

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jul 15, 2024

This pull request removes unused actions:

  • transfer_asset
  • stake
  • activate_account2
  • add_activated_account2

@moreal moreal requested review from ipdae and U-lis July 15, 2024 00:51
@moreal moreal self-assigned this Jul 15, 2024
@moreal moreal marked this pull request as draft July 15, 2024 00:55
@moreal moreal marked this pull request as ready for review July 15, 2024 05:29
@ipdae
Copy link
Member

ipdae commented Jul 16, 2024

Could you please check if there will be any issues when this pull request is applied on https://github.com/planetarium/NineChronicles.DataProvider ?

@moreal
Copy link
Contributor Author

moreal commented Jul 16, 2024

Could you please check if there will be any issues when this pull request is applied on planetarium/NineChronicles.DataProvider ?

Okay, I'll leave a comment after checking it.

@moreal
Copy link
Contributor Author

moreal commented Jul 16, 2024

@ipdae I tried to bump lib9c submodule in NineChronicles.Headless submodule.

Along the way, we also encountered a crash in NineChronicles.Headless, but it was related to a GraphQL query. I think it's okay to lose fields related to action queries or activation.

I get two errors when handling it on the DataProvider side. They come from Stake0 and TransferAsset0. However, both actions have Stake and TransferAsset action handlers, so I think it's fine. As long as you don't follow them from very far back in the block.

@ipdae
Copy link
Member

ipdae commented Jul 16, 2024

@moreal So, are you going to fix the errors caused by this change?

@moreal
Copy link
Contributor Author

moreal commented Jul 16, 2024

@moreal So, are you going to fix the errors caused by this change?

@ipdae Yes. Then I'll open two pull requests to NineChronicles.Headless development and NineChronicles.DataProvider development as draft state, and I'll let you know.

@moreal moreal force-pushed the unused-actions branch 3 times, most recently from c0291c8 to 885fa09 Compare July 22, 2024 06:25
@U-lis
Copy link
Contributor

U-lis commented Aug 19, 2024

@moreal Any updates?
Please update base branch (development) and check it is still mergeable.

@moreal
Copy link
Contributor Author

moreal commented Aug 19, 2024

@U-lis Thanks to check this pull request. But I don't have time to do what follows. So I'll turn this pull request to draft state and you can ignore this pull request until this pull request reopend.

@moreal moreal marked this pull request as draft August 19, 2024 08:26
@moreal moreal force-pushed the unused-actions branch 2 times, most recently from f3b511f to e088a94 Compare August 29, 2024 04:04
@moreal moreal force-pushed the unused-actions branch 4 times, most recently from 821feec to 70a1bec Compare September 5, 2024 22:25
@moreal
Copy link
Contributor Author

moreal commented Sep 6, 2024

After planetarium/NineChronicles.Headless#2540 PR merged, I'll merge this pull request and bump to headless and other projects.

@moreal moreal added the refactoring Refactoring label Sep 11, 2024
@moreal moreal marked this pull request as ready for review September 22, 2024 23:51
@moreal moreal merged commit b81f580 into planetarium:development Sep 23, 2024
8 checks passed
@moreal moreal deleted the unused-actions branch September 23, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants