-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused actions #2685
Remove unused actions #2685
Conversation
Could you please check if there will be any issues when this pull request is applied on https://github.com/planetarium/NineChronicles.DataProvider ? |
Okay, I'll leave a comment after checking it. |
@ipdae I tried to bump lib9c submodule in NineChronicles.Headless submodule. Along the way, we also encountered a crash in NineChronicles.Headless, but it was related to a GraphQL query. I think it's okay to lose fields related to action queries or activation. I get two errors when handling it on the DataProvider side. They come from Stake0 and TransferAsset0. However, both actions have Stake and TransferAsset action handlers, so I think it's fine. As long as you don't follow them from very far back in the block. |
@moreal So, are you going to fix the errors caused by this change? |
c0291c8
to
885fa09
Compare
@moreal Any updates? |
@U-lis Thanks to check this pull request. But I don't have time to do what follows. So I'll turn this pull request to draft state and you can ignore this pull request until this pull request reopend. |
f3b511f
to
e088a94
Compare
821feec
to
70a1bec
Compare
After planetarium/NineChronicles.Headless#2540 PR merged, I'll merge this pull request and bump to headless and other projects. |
70a1bec
to
05943bc
Compare
05943bc
to
355d095
Compare
355d095
to
27001c3
Compare
This pull request removes unused actions:
transfer_asset
stake
activate_account2
add_activated_account2