Implement NCIP-18 #2440

ipdae · 2024-03-06T08:42:42Z

resolve Implement NCIP-18 #2438

pull-request-quantifier-deprecated · 2024-03-06T08:42:47Z

This PR has 130 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +130 -0
Percentile : 46%

Total files changed: 4

Change summary by file extension:
.cs : +130 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

jckdotim · 2024-03-07T06:50:10Z

@planetarium/9c-dev it might be sensitive code because it directly handles NCG. I will also take a quick look, but I hope at least 1 person need to review the whole execution code very carefully so that we can avoid potential vulnerability regarding it. thanks.

Lib9c/Action/RetrieveAvatarAssets.cs

moreal

It seems okay to me. We should care about TryGetAvatarState logic's avatar ownership check spec not change.

.Lib9c.Tests/Action/RetrieveAvatarAssetsTest.cs

moreal · 2024-03-08T08:34:04Z

Lib9c/Action/RetrieveAvatarAssets.cs

+            context.UseGas(1);
+            Address signer = context.Signer;
+            var state = context.PreviousState;
+            if (state.TryGetAvatarState(signer, AvatarAddress, out _))


If this line's purpose is only to check AvatarAddress is the address of context.Signer's avatar, TryGetAvatarState() method can be too heavy. It should deserialize AvatarState from raw bencodex. It may affect to this action's performance.

it would be better to just call GetAgentState and then check the agentState.AvatarAddresses 🤔

pull-request-quantifier-deprecated · 2024-03-08T08:42:25Z

This PR has 145 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +145 -0
Percentile : 49%

Total files changed: 4

Change summary by file extension:
.cs : +145 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-03-08T08:47:03Z

This PR has 145 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +145 -0
Percentile : 49%

Total files changed: 4

Change summary by file extension:
.cs : +145 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-03-08T09:03:09Z

This PR has 146 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Medium
Size       : +146 -0
Percentile : 49.2%

Total files changed: 4

Change summary by file extension:
.cs : +146 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

ipdae added 2 commits March 5, 2024 18:33

Disable MsgPack003

17fea4c

Introduce RetrieveAvatarAssets

4869bdc

ipdae added the enhancement New feature or request label Mar 6, 2024

ipdae requested review from jckdotim, Junyong-Suh and a team March 6, 2024 08:42

ipdae self-assigned this Mar 6, 2024

pull-request-quantifier-deprecated bot added the Medium label Mar 6, 2024

moreal reviewed Mar 7, 2024

View reviewed changes

Lib9c/Action/RetrieveAvatarAssets.cs Outdated Show resolved Hide resolved

Delete balance check

d4a4156

ipdae requested a review from moreal March 8, 2024 07:58

moreal approved these changes Mar 8, 2024

View reviewed changes

moreal suggested changes Mar 8, 2024

View reviewed changes

.Lib9c.Tests/Action/RetrieveAvatarAssetsTest.cs Outdated Show resolved Hide resolved

Change exception type

f089d44

moreal approved these changes Mar 8, 2024

View reviewed changes

Check AgentState.avatarAddresses instead of GetAvatarState

6d0b53b

ipdae merged commit e29b5b9 into release/1.10.0 Mar 11, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement NCIP-18 #2440

Implement NCIP-18 #2440

ipdae commented Mar 6, 2024

pull-request-quantifier-deprecated bot commented Mar 6, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

jckdotim commented Mar 7, 2024

moreal left a comment

moreal Mar 8, 2024

ipdae Mar 8, 2024

pull-request-quantifier-deprecated bot commented Mar 8, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 8, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 8, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

Implement NCIP-18 #2440

Implement NCIP-18 #2440

Conversation

ipdae commented Mar 6, 2024

pull-request-quantifier-deprecated bot commented Mar 6, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

jckdotim commented Mar 7, 2024

moreal left a comment

Choose a reason for hiding this comment

moreal Mar 8, 2024

Choose a reason for hiding this comment

ipdae Mar 8, 2024

Choose a reason for hiding this comment

pull-request-quantifier-deprecated bot commented Mar 8, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 8, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 8, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output