Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action 최적화: DailyReward 하드포크를 다른 액션에도 반영 #2496

Closed
sonohoshi opened this issue Mar 28, 2024 · 12 comments · Fixed by #2502
Closed

Action 최적화: DailyReward 하드포크를 다른 액션에도 반영 #2496

sonohoshi opened this issue Mar 28, 2024 · 12 comments · Fixed by #2502
Assignees
@sonohoshi
Milestone
v170.0.0

Comments

@sonohoshi
Copy link
Member

sonohoshi commented Mar 28, 2024 •
edited
Loading

https://github.com/planetarium/lib9c/tree/improve/action-execute
https://github.com/planetarium/lib9c/tree/migrate/for-action-point
ref: #2478 , #2495

  • AvatarState.actionPoint 필드에 접근하는것들
  • AvatarState.UseAp() 를 사용하는 부분들
@sonohoshi sonohoshi self-assigned this Mar 28, 2024
@sonohoshi sonohoshi converted this from a draft issue Mar 28, 2024
@sonohoshi sonohoshi moved this from Todo to In Progress in Nine Chronicles Mar 29, 2024
@sonohoshi
Copy link
Member Author

sonohoshi commented Mar 29, 2024 •
edited
Loading

AvatarState.dailRewardReceivedIndex를 참조

  • DailyReward
  • DailyReward2
  • MigrationAvatarState

@sonohoshi
Copy link
Member Author

AvatarState.actionPoint를 참조
image

@sonohoshi
Copy link
Member Author

일단 AP를 실제로 사용하지 않는데 참조하려하거나... 이런 부분 코드부터 정리해보기로(ItemEnhancement 등)

@sonohoshi
Copy link
Member Author

  • 82c37f5 에서 ItemEnhancement의 무의미한 참조를 제거
  • ea5897f 에서 ChargeActionPoint가 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • 10a0651 에서 CombinationEquipment가 필요한 경우 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • 62c6b62 에서 CombinationConsumable가 필요한 경우 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • d7b6f51 에서 EventConsumableItemCrafts가 필요한 경우 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • a50cf1a 에서 Grinding이 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • 55822a3 에서 HackAndSlash가 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • 3ae2140 에서 HAS Sweep이 ActionPointModule을 사용하도록 반영

@sonohoshi
Copy link
Member Author

  • 3b170dd 에서 AvatarState.UseAp() 메소드를 InventoryExtensions로 옮겨서 ActionPointModule을 사용하도록 반영
  • 6a5c4f3 에서 AvatarState.UseAp()를 쓰던 부분을 모두 InventoryExtensions.UseActionPoint() 를 쓰도록 반영

@sonohoshi sonohoshi mentioned this issue Apr 1, 2024
Merged
@sonohoshi sonohoshi moved this from In Progress to Review in Nine Chronicles Apr 1, 2024
@sonohoshi sonohoshi added this to the v170.0.0 milestone Apr 1, 2024
@sonohoshi sonohoshi linked a pull request Apr 1, 2024 that will close this issue
Migrate AvatarState.actionPoint to use ActionPointModule #2502
Merged
@sonohoshi
Copy link
Member Author

패시브 마이그레이션이 안되고 있다는 리뷰를 받아 이를 반영중

@sonohoshi sonohoshi moved this from Review to Merged in Nine Chronicles Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Merged to Done in Nine Chronicles Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonohoshi sonohoshi

Labels
None yet
Projects
Nine Chronicles
Archived in project
Milestone
v170.0.0
Development

Successfully merging a pull request may close this issue.

Migrate AvatarState.actionPoint to use ActionPointModule planetarium/lib9c
1 participant
@sonohoshi