Skip to content

Commit

Permalink
Merge pull request #2681 from planetarium/feature/reduce-conditional-…
Browse files Browse the repository at this point in the history
…compilation

GameConfig 정리
  • Loading branch information
eugene-doobu authored Jul 19, 2024
2 parents 2772edf + dc840f7 commit c81505a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 20 deletions.
18 changes: 3 additions & 15 deletions Lib9c/GameConfig.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,16 @@ namespace Nekoyume
{
public static class GameConfig
{
// ReSharper disable once ConvertToConstant.Global
#if LIB9C_DEV_EXTENSIONS || UNITY_EDITOR
public const bool IsEditor = true;
public static readonly bool IsEditor = true;
#else
public const bool IsEditor = false;
public static readonly bool IsEditor = false;
#endif

public const int SlotCount = 3;
public const float WaitSeconds = 180f;
public const string AvatarNickNamePattern = @"^[0-9a-zA-Z]{2,20}$";
public const string DiscordLink = "https://discord.gg/NqshYve";

public const string BlockExplorerLinkFormat =
"http://explorer.libplanet.io/9c-beta/account/?{0}";

public const float PlayerSpeechBreakTime = 2f;
public const int MimisbrunnrWorldId = 10001;
public const int MimisbrunnrStartStageId = 10000001;
public const int DefaultAttackId = 100000;
Expand All @@ -33,15 +28,8 @@ public static class GameConfig
public const int DefaultAvatarArmorId = 10200000;

//TODO 안쓰는 프리팹과 함께 삭제해야함
public const int CombineEquipmentCostAP = 5;
public const int CombineEquipmentCostNCG = 10;
public const int EnhanceEquipmentCostAP = 0;

public const int RankingRewardFirst = 50;
public const int RankingRewardSecond = 30;
public const int RankingRewardThird = 10;

public const int ArenaActivationCostNCG = 100;
public const int ArenaScoreDefault = 1000;
public const int ArenaChallengeCountMax = 5;
public const int MaximumProbability = 10000;
Expand Down
5 changes: 0 additions & 5 deletions Lib9c/TableData/Item/ItemRequirementSheet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@ public class Row : SheetRow<int>
public override void Set(IReadOnlyList<string> fields)
{
ItemId = ParseInt(fields[0]);
#if UNITY_EDITOR
Level = GameConfig.IsEditor ? 1 : ParseInt(fields[1]);
MimisLevel = GameConfig.IsEditor ? 1 : ParseInt(fields[2]);
#else
Level = ParseInt(fields[1]);
MimisLevel = ParseInt(fields[2]);
#endif
}
}

Expand Down

0 comments on commit c81505a

Please sign in to comment.