Merge pull request #2208 from moreal/limit-claim-data-size

Limit ClaimItems.ClaimData's size to 100
planetarium · Nov 7, 2023 · b96db26 · b96db26
2 parents 0411bb7 + d15fa76
commit b96db26
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/.Lib9c.Tests/Action/ClaimItemsTest.cs b/.Lib9c.Tests/Action/ClaimItemsTest.cs
@@ -2,6 +2,7 @@ namespace Lib9c.Tests.Action
 {
     using System;
     using System.Collections.Generic;
+    using System.Collections.Immutable;
     using System.Linq;
     using Libplanet.Action.State;
     using Libplanet.Crypto;
@@ -182,6 +183,26 @@ public void Execute_WithMultipleRecipients()
             Assert.Equal(1, inventory2.Items.First(x => x.item.Id == _itemIds[2]).count);
         }
 
+        [Fact]
+        public void Execute_WithIncorrectClaimData()
+        {
+            var fungibleAssetValues = _currencies.Select(currency => currency * 1).ToList();
+
+            var action = new ClaimItems(Enumerable.Repeat(0, 101)
+                .Select(_ => (new PrivateKey().ToAddress(),
+                    (IReadOnlyList<FungibleAssetValue>)fungibleAssetValues))
+                .ToImmutableList());
+
+            Assert.Throws<ArgumentOutOfRangeException>("ClaimData", () =>
+                action.Execute(new ActionContext
+                {
+                    PreviousState = _initialState,
+                    Signer = _signerAddress,
+                    BlockIndex = 0,
+                    RandomSeed = 0,
+                }));
+        }
+
         private IAccount GenerateAvatar(IAccount state, out Address avatarAddress)
         {
             var address = new PrivateKey().ToAddress();

diff --git a/Lib9c/Action/ClaimItems.cs b/Lib9c/Action/ClaimItems.cs
@@ -19,6 +19,7 @@ namespace Nekoyume.Action
     public class ClaimItems : GameAction, IClaimItems
     {
         private const string ActionTypeText = "claim_items";
+        private const int MaxClaimDataCount = 100;
 
         public IReadOnlyList<(Address address, IReadOnlyList<FungibleAssetValue> fungibleAssetValues)> ClaimData { get; private set; }
 
@@ -57,6 +58,14 @@ public override IAccount Execute(IActionContext context)
         {
             context.UseGas(1);
 
+            if (ClaimData.Count > MaxClaimDataCount)
+            {
+                throw new ArgumentOutOfRangeException(
+                    nameof(ClaimData),
+                    ClaimData.Count,
+                    $"ClaimData should be less than {MaxClaimDataCount}");
+            }
+
             var states = context.PreviousState;
             var random = context.GetRandom();
             var itemSheet = states.GetSheets(containItemSheet: true).GetItemSheet();